Skip to content

Check internet availability #137

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 3 commits into
base: master
Choose a base branch
from
Open

Check internet availability #137

wants to merge 3 commits into from

Conversation

fabik111
Copy link
Contributor

@fabik111 fabik111 commented Apr 7, 2025 •
edited
Loading

This PR introduce a step of validation that the board has access to internet before giving the "Connected" result.

The PR requires this PR on MKRNB lib

@github-actions GitHub Actions

This comment was marked as outdated.

Sign in to view
@per1234 per1234 added the topic: code Related to content of the project itself label Apr 7, 2025
@github-actions GitHub Actions

This comment was marked as outdated.

Sign in to view
@fabik111 fabik111 force-pushed the check-access-internet branch from 218698d to e853987 Compare April 8, 2025 09:45
@github-actions GitHub Actions

This comment was marked as outdated.

Sign in to view
@github-actions GitHub Actions

This comment was marked as outdated.

Sign in to view
@fabik111 fabik111 force-pushed the check-access-internet branch from cce1a4c to 0314cf5 Compare April 10, 2025 13:52
@github-actions GitHub Actions

This comment was marked as outdated.

Sign in to view
@andreagilardoni andreagilardoni self-requested a review April 18, 2025 06:56
@fabik111 fabik111 force-pushed the check-access-internet branch from 0314cf5 to 54b93d6 Compare April 18, 2025 14:27
@github-actions GitHub Actions
Copy link

Memory usage change @ 54b93d6

Board flash % RAM for global variables %
arduino:esp32:nano_nora 🔺 +496 - +824 +0.02 - +0.03 🔺 +8 - +96 0.0 - +0.03
arduino:mbed:envie_m7 N/A N/A N/A N/A
arduino:mbed_edge:edge_control 🔺 +144 - +1272 +0.01 - +0.13 🔺 +8 - +224 0.0 - +0.09
arduino:mbed_giga:giga 🔺 +144 - +1080 +0.01 - +0.05 🔺 +8 - +96 0.0 - +0.02
arduino:mbed_nano:nanorp2040connect 🔺 +170 - +776 0.0 - 0.0 🔺 +8 - +96 0.0 - +0.04
arduino:mbed_nicla:nicla_vision 🔺 +208 - +1080 +0.01 - +0.05 🔺 +8 - +96 0.0 - +0.02
arduino:mbed_opta:opta 🔺 +144 - +1176 +0.01 - +0.06 🔺 0 - +8 0.0 - 0.0
arduino:mbed_portenta:envie_m7 N/A N/A N/A N/A
arduino:renesas_portenta:portenta_c33 🔺 +184 - +19744 +0.01 - +0.94 🔺 +8 - +660 0.0 - +0.13
arduino:renesas_uno:unor4wifi 🔺 +176 - +624 +0.07 - +0.24 🔺 +8 - +96 +0.02 - +0.29
arduino:samd:mkr1000 🔺 +176 - +752 +0.07 - +0.29 🔺 +8 - +96 +0.02 - +0.29
arduino:samd:mkrgsm1400 🔺 +176 - +320 +0.07 - +0.12 🔺 +8 - +228 +0.02 - +0.7
arduino:samd:mkrnb1500 🔺 +176 - +304 +0.07 - +0.12 🔺 +8 - +228 +0.02 - +0.7
arduino:samd:mkrwan1300 🔺 +176 - +256 +0.07 - +0.1 🔺 +8 - +52 +0.02 - +0.16
arduino:samd:mkrwan1310 🔺 +168 - +256 +0.06 - +0.1 🔺 +8 - +52 +0.02 - +0.16
arduino:samd:mkrwifi1010 🔺 +176 - +680 +0.07 - +0.26 🔺 +8 - +96 +0.02 - +0.29
arduino:samd:nano_33_iot 🔺 +168 - +680 +0.06 - +0.26 🔺 +8 - +96 +0.02 - +0.29
esp32:esp32:esp32 🔺 +500 - +764 +0.04 - +0.06 🔺 +8 - +96 0.0 - +0.03
esp8266:esp8266:huzzah 🔺 +432 - +432 +0.04 - +0.04 🔺 +96 - +96 +0.12 - +0.12
rp2040:rp2040:rpipicow 🔺 +392 - +1592 +0.02 - +0.08 🔺 +24 - +96 +0.01 - +0.04
Click for full report table
Board examples/ConnectionHandlerDemo
flash		 % examples/ConnectionHandlerDemo
RAM for global variables		 % examples/ConnectionHandlerDemo-Notecard
flash		 % examples/ConnectionHandlerDemo-Notecard
RAM for global variables		 %
arduino:esp32:nano_nora 824 0.03 96 0.03 496 0.02 8 0.0
arduino:mbed:envie_m7 N/A N/A N/A N/A N/A N/A N/A N/A
arduino:mbed_edge:edge_control 1272 0.13 224 0.09 144 0.01 8 0.0
arduino:mbed_giga:giga 1080 0.05 96 0.02 144 0.01 8 0.0
arduino:mbed_nano:nanorp2040connect 776 0.0 96 0.04 170 0.0 8 0.0
arduino:mbed_nicla:nicla_vision 1080 0.05 96 0.02 208 0.01 8 0.0
arduino:mbed_opta:opta 1176 0.06 0 0.0 144 0.01 8 0.0
arduino:mbed_portenta:envie_m7 N/A N/A N/A N/A N/A N/A N/A N/A
arduino:renesas_portenta:portenta_c33 19744 0.94 660 0.13 184 0.01 8 0.0
arduino:renesas_uno:unor4wifi 624 0.24 96 0.29 176 0.07 8 0.02
arduino:samd:mkr1000 752 0.29 96 0.29 176 0.07 8 0.02
arduino:samd:mkrgsm1400 320 0.12 228 0.7 176 0.07 8 0.02
arduino:samd:mkrnb1500 304 0.12 228 0.7 176 0.07 8 0.02
arduino:samd:mkrwan1300 256 0.1 52 0.16 176 0.07 8 0.02
arduino:samd:mkrwan1310 256 0.1 52 0.16 168 0.06 8 0.02
arduino:samd:mkrwifi1010 680 0.26 96 0.29 176 0.07 8 0.02
arduino:samd:nano_33_iot 680 0.26 96 0.29 168 0.06 8 0.02
esp32:esp32:esp32 764 0.06 96 0.03 500 0.04 8 0.0
esp8266:esp8266:huzzah 432 0.04 96 0.12
rp2040:rp2040:rpipicow 1592 0.08 96 0.04 392 0.02 24 0.01
Click for full report CSV 
Board,examples/ConnectionHandlerDemo<br>flash,%,examples/ConnectionHandlerDemo<br>RAM for global variables,%,examples/ConnectionHandlerDemo-Notecard<br>flash,%,examples/ConnectionHandlerDemo-Notecard<br>RAM for global variables,%
arduino:esp32:nano_nora,824,0.03,96,0.03,496,0.02,8,0.0
arduino:mbed:envie_m7,N/A,N/A,N/A,N/A,N/A,N/A,N/A,N/A
arduino:mbed_edge:edge_control,1272,0.13,224,0.09,144,0.01,8,0.0
arduino:mbed_giga:giga,1080,0.05,96,0.02,144,0.01,8,0.0
arduino:mbed_nano:nanorp2040connect,776,0.0,96,0.04,170,0.0,8,0.0
arduino:mbed_nicla:nicla_vision,1080,0.05,96,0.02,208,0.01,8,0.0
arduino:mbed_opta:opta,1176,0.06,0,0.0,144,0.01,8,0.0
arduino:mbed_portenta:envie_m7,N/A,N/A,N/A,N/A,N/A,N/A,N/A,N/A
arduino:renesas_portenta:portenta_c33,19744,0.94,660,0.13,184,0.01,8,0.0
arduino:renesas_uno:unor4wifi,624,0.24,96,0.29,176,0.07,8,0.02
arduino:samd:mkr1000,752,0.29,96,0.29,176,0.07,8,0.02
arduino:samd:mkrgsm1400,320,0.12,228,0.7,176,0.07,8,0.02
arduino:samd:mkrnb1500,304,0.12,228,0.7,176,0.07,8,0.02
arduino:samd:mkrwan1300,256,0.1,52,0.16,176,0.07,8,0.02
arduino:samd:mkrwan1310,256,0.1,52,0.16,168,0.06,8,0.02
arduino:samd:mkrwifi1010,680,0.26,96,0.29,176,0.07,8,0.02
arduino:samd:nano_33_iot,680,0.26,96,0.29,168,0.06,8,0.02
esp32:esp32:esp32,764,0.06,96,0.03,500,0.04,8,0.0
esp8266:esp8266:huzzah,432,0.04,96,0.12,,,,
rp2040:rp2040:rpipicow,1592,0.08,96,0.04,392,0.02,24,0.01

fabik111 added 3 commits May 7, 2025 17:49
@fabik111
set connected state after checking internet availability
12a4c63 
use ping for all connectivity

compile fix for esp8266 and esp32

remove check ping for mkrnb
@fabik111
update init interval
a5cf9a0
@fabik111
enable or disable check internet availability
c2a81e5
@fabik111 fabik111 force-pushed the check-access-internet branch from 54b93d6 to c2a81e5 Compare May 7, 2025 15:50
@github-actions GitHub Actions
Copy link

github-actions bot commented May 7, 2025

Memory usage change @ c2a81e5

Board flash % RAM for global variables %
arduino:esp32:nano_nora 🔺 +4 - +48 0.0 - 0.0 0 - 0 0.0 - 0.0
arduino:mbed:envie_m7 N/A N/A N/A N/A
arduino:mbed_edge:edge_control 🔺 0 - +1000 0.0 - +0.1 0 - 0 0.0 - 0.0
arduino:mbed_giga:giga 🔺 0 - +872 0.0 - +0.04 0 - 0 0.0 - 0.0
arduino:mbed_nano:nanorp2040connect 🔺 0 - +414 0.0 - 0.0 0 - 0 0.0 - 0.0
arduino:mbed_nicla:nicla_vision 🔺 0 - +872 0.0 - +0.04 0 - 0 0.0 - 0.0
arduino:mbed_opta:opta 🔺 0 - +904 0.0 - +0.05 0 - 0 0.0 - 0.0
arduino:mbed_portenta:envie_m7 N/A N/A N/A N/A
arduino:renesas_portenta:portenta_c33 🔺 +8 - +19464 0.0 - +0.93 🔺 0 - +532 0.0 - +0.1
arduino:renesas_uno:unor4wifi 🔺 0 - +360 0.0 - +0.14 0 - 0 0.0 - 0.0
arduino:samd:mkr1000 🔺 0 - +488 0.0 - +0.19 0 - 0 0.0 - 0.0
arduino:samd:mkrgsm1400 🔺 0 - +8 0.0 - 0.0 0 - 0 0.0 - 0.0
arduino:samd:mkrnb1500 0 - 0 0.0 - 0.0 0 - 0 0.0 - 0.0
arduino:samd:mkrwan1300 0 - 0 0.0 - 0.0 0 - 0 0.0 - 0.0
arduino:samd:mkrwan1310 0 - 0 0.0 - 0.0 0 - 0 0.0 - 0.0
arduino:samd:mkrwifi1010 🔺 0 - +416 0.0 - +0.16 0 - 0 0.0 - 0.0
arduino:samd:nano_33_iot 🔺 0 - +416 0.0 - +0.16 0 - 0 0.0 - 0.0
esp32:esp32:esp32 🔺 +8 - +52 0.0 - 0.0 0 - 0 0.0 - 0.0
esp8266:esp8266:huzzah 🔺 +64 - +64 +0.01 - +0.01 0 - 0 0.0 - 0.0
rp2040:rp2040:rpipicow 🔺 +8 - +1264 0.0 - +0.06 0 - 0 0.0 - 0.0
Click for full report table
Board examples/ConnectionHandlerDemo
flash		 % examples/ConnectionHandlerDemo
RAM for global variables		 % examples/ConnectionHandlerDemo-Notecard
flash		 % examples/ConnectionHandlerDemo-Notecard
RAM for global variables		 %
arduino:esp32:nano_nora 48 0.0 0 0.0 4 0.0 0 0.0
arduino:mbed:envie_m7 N/A N/A N/A N/A N/A N/A N/A N/A
arduino:mbed_edge:edge_control 1000 0.1 0 0.0 0 0.0 0 0.0
arduino:mbed_giga:giga 872 0.04 0 0.0 0 0.0 0 0.0
arduino:mbed_nano:nanorp2040connect 414 0.0 0 0.0 0 0.0 0 0.0
arduino:mbed_nicla:nicla_vision 872 0.04 0 0.0 0 0.0 0 0.0
arduino:mbed_opta:opta 904 0.05 0 0.0 0 0.0 0 0.0
arduino:mbed_portenta:envie_m7 N/A N/A N/A N/A N/A N/A N/A N/A
arduino:renesas_portenta:portenta_c33 19464 0.93 532 0.1 8 0.0 0 0.0
arduino:renesas_uno:unor4wifi 360 0.14 0 0.0 0 0.0 0 0.0
arduino:samd:mkr1000 488 0.19 0 0.0 0 0.0 0 0.0
arduino:samd:mkrgsm1400 8 0.0 0 0.0 0 0.0 0 0.0
arduino:samd:mkrnb1500 0 0.0 0 0.0 0 0.0 0 0.0
arduino:samd:mkrwan1300 0 0.0 0 0.0 0 0.0 0 0.0
arduino:samd:mkrwan1310 0 0.0 0 0.0 0 0.0 0 0.0
arduino:samd:mkrwifi1010 416 0.16 0 0.0 0 0.0 0 0.0
arduino:samd:nano_33_iot 416 0.16 0 0.0 0 0.0 0 0.0
esp32:esp32:esp32 52 0.0 0 0.0 8 0.0 0 0.0
esp8266:esp8266:huzzah 64 0.01 0 0.0
rp2040:rp2040:rpipicow 1264 0.06 0 0.0 8 0.0 0 0.0
Click for full report CSV 
Board,examples/ConnectionHandlerDemo<br>flash,%,examples/ConnectionHandlerDemo<br>RAM for global variables,%,examples/ConnectionHandlerDemo-Notecard<br>flash,%,examples/ConnectionHandlerDemo-Notecard<br>RAM for global variables,%
arduino:esp32:nano_nora,48,0.0,0,0.0,4,0.0,0,0.0
arduino:mbed:envie_m7,N/A,N/A,N/A,N/A,N/A,N/A,N/A,N/A
arduino:mbed_edge:edge_control,1000,0.1,0,0.0,0,0.0,0,0.0
arduino:mbed_giga:giga,872,0.04,0,0.0,0,0.0,0,0.0
arduino:mbed_nano:nanorp2040connect,414,0.0,0,0.0,0,0.0,0,0.0
arduino:mbed_nicla:nicla_vision,872,0.04,0,0.0,0,0.0,0,0.0
arduino:mbed_opta:opta,904,0.05,0,0.0,0,0.0,0,0.0
arduino:mbed_portenta:envie_m7,N/A,N/A,N/A,N/A,N/A,N/A,N/A,N/A
arduino:renesas_portenta:portenta_c33,19464,0.93,532,0.1,8,0.0,0,0.0
arduino:renesas_uno:unor4wifi,360,0.14,0,0.0,0,0.0,0,0.0
arduino:samd:mkr1000,488,0.19,0,0.0,0,0.0,0,0.0
arduino:samd:mkrgsm1400,8,0.0,0,0.0,0,0.0,0,0.0
arduino:samd:mkrnb1500,0,0.0,0,0.0,0,0.0,0,0.0
arduino:samd:mkrwan1300,0,0.0,0,0.0,0,0.0,0,0.0
arduino:samd:mkrwan1310,0,0.0,0,0.0,0,0.0,0,0.0
arduino:samd:mkrwifi1010,416,0.16,0,0.0,0,0.0,0,0.0
arduino:samd:nano_33_iot,416,0.16,0,0.0,0,0.0,0,0.0
esp32:esp32:esp32,52,0.0,0,0.0,8,0.0,0,0.0
esp8266:esp8266:huzzah,64,0.01,0,0.0,,,,
rp2040:rp2040:rpipicow,1264,0.06,0,0.0,8,0.0,0,0.0

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@andreagilardoni andreagilardoni andreagilardoni approved these changes

Assignees
No one assigned
Labels
topic: code Related to content of the project itself
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@fabik111 @andreagilardoni @per1234